Closed Reisclef closed 2 years ago
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @Reisclef.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check
as a comment to the PR.
Thanks for the PR, a quick note (we definitely need to get this noted clearly) these plugin readmes are automatically pulled in from their respective repositories, so in this case, the change should be made in https://github.com/NativeScript/firebase/blob/main/packages/firebase-crashlytics/README.md as merging this here would be overwritten with the repo version the next time our CI job runs (daily).
Sure. It wasn't immediately clear where this change would be made.
I'm happy for someone else to make the necessary change on the other repo as I didn't specifically want to sign the CLA just for a doc change recommendation. I'll close this one and leave it to someone to raise a PR on the correct repo.
@Reisclef sure thing - I'll make the change real quick there! 👍
Thank you @Reisclef https://github.com/NativeScript/docs-new#important-note-about-plugin-docs
As per Firebase docs, if a user wants to opt out of crashlytics, you would set the value in setCrashlyticsCollectionEnabled to false, not true.
https://firebase.google.com/docs/reference/swift/firebasecrashlytics/api/reference/Classes/Crashlytics#setcrashlyticscollectionenabled_: