NativeScript / firebase

Modular Firebase 🔥 implementation for NativeScript. Supports both iOS & Android platforms for all Firebase services.
https://docs.nativescript.org/plugins/firebase-core.html
Apache License 2.0
52 stars 46 forks source link

[Android] Can't load ads from Ad Manager #107

Closed maxximee closed 1 year ago

maxximee commented 1 year ago

On Android, but probably ios as well, wasn't able to debug ios yet (ads don't load at all on ios so far). Loading Ads with admob unit id works but loading with AdManager doesn't. In https://github.com/NativeScript/firebase/blob/3de8339d6056bbe5ecf584dbb79a3241ddd990f2/packages/firebase-admob/src-native/android/admob/src/main/java/org/nativescript/firebase/admob/FirebaseAdmob.kt#494

fun load(adLoader: AdLoader, request: String, isAdManager: Boolean)

The load method shows isAdManager boolean parameter, but the load method in BannerAd for example only takes a RequestOptions: load(options?: RequestOptions) Where RequestOptions are: `export interface RequestOptions { contentUrl?: undefined | string; keywords?: string[]; networkExtras?: undefined | {

};
requestAgent?: undefined | string;
requestNonPersonalizedAdsOnly?: undefined | false | true;

}` Maybe it's the requestAgent field, but I can't find any documentation

maxximee commented 1 year ago

Issue seemed to be on ad manager side.