search

NativeScript / firebase

Modular Firebase 🔥 implementation for NativeScript. Supports both iOS & Android platforms for all Firebase services.
https://docs.nativescript.org/plugins/firebase-core.html
Apache License 2.0
52 stars 46 forks source link

fix(core): initializeApp default app not resolved #255

Closed jnorkus closed 2 months ago

jnorkus commented 2 months ago

When hot reloading using HMR, the default app is already set and is not resolved correctly.

cla-bot[bot] commented 2 months ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @jnorkus. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

jnorkus commented 2 months ago

@cla-bot check

cla-bot[bot] commented 2 months ago

The cla-bot has been summoned, and re-checked this pull request!

vallemar commented 2 months ago

@jnorkus very nice, I think I struggled with this a long time ago. I simply stored the application in a global variable and if it was not null I skipped the initialization step, but this is much better and solves the problem!