NativeScript / mlkit

Apache License 2.0
24 stars 9 forks source link

Bug: Selection of Barcode formats not working #11

Closed cjohn001 closed 2 years ago

cjohn001 commented 2 years ago

If one sets an array of Barcode formats to be detected the formats are not accepted by the plugin. The bug is in the following line

https://github.com/NativeScript/mlkit/blob/c7ee4981e0457293e655d75dbf83b643fac48606/packages/mlkit-core/index.ios.ts#L244

value.indexOf(BarcodeFormats.ALL) === -1 => which is true for the if clause is to be expected if BarcodeFormats.All is not set but one or several other formats.

You can try with the demo app from here : https://github.com/cjohn001/mlkit-test Just run on IOS and set a breakpoint to the linked line.