search

NativeScript / nativescript-app-sync

♻️ Update your app without going through the app store!
MIT License
125 stars 24 forks source link

The nativescript-app-sync is not compatible with Sidekick iOS cloud build #27

Closed miiihi closed 5 years ago

miiihi commented 5 years ago

To recreate:

  1. add the nativescript-app-sync to the project (with tns plugin add nativescript-app-sync
  2. start a cloud iOS build in Sidekick.
  3. the build fails on npm install...

The error looks the same as described here https://github.com/NativeScript/sidekick-feedback/issues/288, nativescript-app-sync's postinstall hook is trying to install something into '/usr/local/lib/node_modules', which it is not allowed...

Detailed sidekick log available here https://gist.github.com/miiihi/3967f3ced0210a1d7297fbfebc7e4016

EddyVerbruggen commented 5 years ago

I think it's this part of the postinstall script: npm i -g nativescript-app-sync-cli.

EddyVerbruggen commented 5 years ago

Can you give 1.0.4 a spin? I've removed that command as it's already documented in the readme you should run this yourself anyway.

miiihi commented 5 years ago

Agree, postinstall hook shouldn't do the global install. Will test soon.

miiihi commented 5 years ago

Tested and confirmed as fixed. And kudos for one of the fastes fixes ever seen! Thanks!

EddyVerbruggen commented 5 years ago

And thanks you for the decent issue-report. That helped!