search

NativeScript / nativescript-app-sync

♻️ Update your app without going through the app store!
MIT License
125 stars 24 forks source link

Seemingly unnecessary sub-dependency "properties" causes problems #43

Closed crowmagnumb closed 4 years ago

crowmagnumb commented 4 years ago 
npm i nativescript-app-sync

... installs sub-dependency node_module "properties". I have 1.0.6 installed. This node_module then conflicts with running nativescript-app-sync and tns commands for different reasons. For tns there is a require(../properties) line in some code that for some reason imports the "properties" node_module instead of the file from the directory within the nativescript code module. I can't remember the problem using the nativescript-app-sync command but its something similar. At any rate, removing the node_modules/properties directory has no ill effect and solves all my problems. So it seems this is an unnecessary sub-dependency.

Anyone else run into this?

EddyVerbruggen commented 4 years ago

I'd love to get rid of it - would you mind doing a PR?

crowmagnumb commented 4 years ago

I didn't look too hard but couldn't find where the dependency was coming from. And frankly I've moved on from this as its too beta for our needs at the moment. I keep running into issues with updates that end up bricking my app as I get a NPE running the appsync code (happening on android) or it reverting to the webstore version and not updating further (happened on one iphone install). Will take a look back when its more developed. Sorry.

EddyVerbruggen commented 4 years ago

I hope we can see you return one day. I'll look into that dependency, thanks again for the report.

EddyVerbruggen commented 4 years ago

@crowmagnumb Just FYI this (removing the properties dependency) was fixed in 1.0.7 which was released last week for #42.

crowmagnumb commented 4 years ago

Ah cheers! Yeah, I'm not gone for sure, just in a pinch right now to get an app on the store. Thanks for all your work!