search

NativeScript / nativescript-app-sync

♻️ Update your app without going through the app store!
MIT License
125 stars 24 forks source link

fix for ns7 (new app structure) #74

Closed weathered-fire-2600 closed 1 year ago

weathered-fire-2600 commented 3 years ago

Referes to https://github.com/NativeScript/nativescript-app-sync/issues/72

Please not that this is major update and not backward compatible with ns6 due to different app structure. Users building ns6 based apps should use v2.0.0 of this plugin.

Currently there is a fix pending for nativescript-hook and I used the feature branch from @NathanWalker

Also one must use the fixed appsync-cli version, see https://github.com/Puracy/nativescript-app-sync-sdk-cli (pull request pending). With this fix you can build and release ns7 based apps to appsync server.

cla-bot[bot] commented 3 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @weathered-fire-2600. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

weathered-fire-2600 commented 3 years ago

@cla-bot check

cla-bot[bot] commented 3 years ago

The cla-bot has been summoned, and re-checked this pull request!

wendt88 commented 3 years ago

@EddyVerbruggen can you please merge it? @weathered-fire-2600 thx!

sivo1981 commented 1 year ago

Any chance this will get merged soon?

cla-bot[bot] commented 1 year ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @weathered-fire-2600. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.