Implemented Canceling uploads

andre-huehn commented 6 years ago

Implemented canceling running uploads

I needed some trickery to get tsc to compile the code. (some casts) I also change the ios implementation to return common.task instead task for that. Please review my changes.

andre-huehn commented 6 years ago

I also added the option to auto delete the file after succesful upload

andre-huehn commented 6 years ago

test and test2 were commits to install from my public fork, i can always undo them later on.

lini commented 6 years ago

Hi and thanks for your work! I have a couple of suggestions that should be addressed before the PR can be merged.

the android permissions should be updated to allow deleting files on the device. The READ_EXTERNAL_STORAGE permission in nativescript-background-http/platforms/android/AndroidManifest.xml should be replaced with WRITE_EXTERNAL_STORAGE (which includes read and write):
```
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
```
package.json files should not be modified for this request as it does not contain updated dependencies. You can undo those so only .ts and .d.ts files are modified.

andre-huehn commented 6 years ago

Done undoing the package.json changes and added the WRITE permissions. Looking forward for the next release. :)

NativeScript / nativescript-background-http

Implemented Canceling uploads #106