search

NativeScript / nativescript-background-http

Background Upload plugin for the NativeScript framework
Apache License 2.0
101 stars 50 forks source link

Documentation of task completion #185

Closed cfjedimaster closed 5 years ago

cfjedimaster commented 5 years ago

In the readme, I do not see any examples of working with the task object. How do I know it's done? How do I monitor it? I've seen in the demo some examples, but shouldn't the readme show a bit more in terms of how to handle the upload?

cfjedimaster commented 5 years ago

Maybe this should be expanded. I'm trying to use the progress event too and while I can console.log the data - shouldn't the docs tell you what is passed to the event?

lini commented 5 years ago

I have updated the code samples in the documentation in #186 If you feel that something is not right or needs to be expanded, feel free to submit a PR.

cfjedimaster commented 5 years ago

This looks really good - thank you!