Performance issue on multiple upload

[closca]

Make sure to check the demo app(s) for sample usage

Make sure to check the existing issues in this repository

If the demo apps cannot help and there is no issue for your problem, tell us about it

Please, ensure your title is less than 63 characters long and starts with a capital letter.

Which platform(s) does your issue occur on?

IOS

Please, provide the following version numbers that your issue occurs with:

• CLI: 5.0.0
• Cross-platform modules: 5.0.1
• Runtime(s):

  "tns-android": {
    "version": "5.0.0"
  },
  "tns-ios": {
    "version": "5.0.0"
  }

• Plugin(s):

  "nativescript-angular": "~6.1.0",
  "nativescript-background-http": "^3.3.0",
  "nativescript-bottombar": "^3.0.8",
  "nativescript-camera": "^4.0.2",
  "nativescript-image-cache": "^1.1.6",
  "nativescript-imagepicker": "^6.0.4",
  "nativescript-keyboardshowing": "^1.0.0",
  "nativescript-loading-indicator": "^2.4.0",
  "nativescript-mediafilepicker": "^2.0.14",
  "nativescript-modal-datetimepicker": "^1.1.10",
  "nativescript-ngx-fonticon": "^4.2.0",
  "nativescript-numeric-keyboard": "^4.0.2",
  "nativescript-onesignal": "^1.0.8",
  "nativescript-photoviewer": "^1.4.0",
  "nativescript-socket.io": "^0.9.0",
  "nativescript-theme-core": "~1.0.4",
  "nativescript-ui-sidedrawer": "^4.3.0",

  Please, tell us how to recreate the issue in as much detail as possible.

  I am using nativescript-imagepicker and the saving file into knownFolders is crashing the app on reald device for lack of memory, and on mac is hammering the CPU and uses 1.5GB of RAM

Is there any code involved?

imageSourceModule.fromAsset(imageAsset).then(imageSource => {
            const folder = fileSystemModule.knownFolders.documents().path;
            const fileName = 'tes.png';
            const path = fileSystemModule.path.join(folder, fileName);
            const saved = imageSource.saveToFile(path, 'png');
            if (saved) {
                let file = fileSystemModule.File.fromPath(path);
                let request = {
                    url: ENV.API_HOST + '/api/v1/upload',
                    method: 'POST',
                    headers: {
                        'Content-Type': 'application/octet-stream',
                        'File-Name': file._name,
                        Origin: ENV.HTTP_ORIGIN,
                        Authorization: `Bearer ${APP_SETTINGS.getString(ENV.AUTH_TOKEN_KEY)}`
                    },
                    description: 'upload'
                };

                let params = [ {
                        name: 'file',
                        filename: file._path,
                        mimeType: mime
                    }];

                let task = imageUploadSession.multipartUpload(params, request);
                task.on('error', response => {
                    console.log(response);
                });
                task.on('responded', (response: IHttpBackgroundOnResponse) => {
                    console.log(response);
                });
            } else {
                alert('Failed to upload image. Try again!');
            }
        });

I suspect that the most expensive part is when is saving the file in the knowFolders. I tried to upload the image directly from gallery without saving in knownFolders but is sending an empty file or something because I can see on server side this mime: node/x-empty

Here is my code for direct upload:

context.authorize()
            .then(() => {
                return context.present();
            })
            .then((selection: ImageAsset[]) => {
                selection.forEach((selectedImage: ImageAsset) => {
                    const iosSelected = selectedImage.ios;
                    let selectedImagePath;
                    if (iosSelected && iosSelected.mediaType === PHAssetMediaType.Image) {
                        const opt = PHImageRequestOptions.new();
                        opt.version = PHImageRequestOptionsVersion.Current;
                        PHImageManager.defaultManager().requestImageDataForAssetOptionsResultHandler(
                            iosSelected, opt, (imageData: NSData, dataUTI: string, orientation: UIImageOrientation, info: any) => {
                                selectedImagePath = info.objectForKey('PHImageFileURLKey').toString();
                                let extension = selectedImagePath.split('.').pop().toLowerCase();
                                let imageBaseName = baseName(selectedImagePath) + '.' + extension;
                                let request = {
                                    url: ENV.API_HOST + '/api/v1/upload',
                                    method: 'POST',
                                    headers: {
                                        'Content-Type': 'application/octet-stream',
                                        'File-Name': imageBaseName,
                                        Origin: ENV.HTTP_ORIGIN,
                                        Authorization: `Bearer ${APP_SETTINGS.getString(ENV.AUTH_TOKEN_KEY)}`
                                    },
                                    description: 'upload'
                                };
                                let params = [{
                                        name: 'file',
                                        filename: selectedImagePath,
                                        mimeType: mime
                                    }];

                                let task = imageUploadSession.multipartUpload(params, request);
                                });

                            });
                    } 
                });
            });

[tbozhikov]

Hi @closca, Check out this demo for uploading images. Tested it in Xcode and Simulator, profiled the memory and did not see any excessive memory usage. Note, that it uses calls to native iOS libs for storing the file to the knownFolders.

Let us know if this works for you.

[elena-p]

Closing the issue due to inactivity