NativeScript / nativescript-background-http

Background Upload plugin for the NativeScript framework
Apache License 2.0
102 stars 50 forks source link

fix(android-upload): Fix some params vars to be a string #252

Closed romulowspp closed 5 years ago

romulowspp commented 5 years ago

PR Checklist

What is the current behavior?

When the parameter payload has a type that isn't a string it throws one Java Exception about wrong type passed to method.

What is the new behavior?

Now you i convert all types in parameter value and name to string.

Fixes #249 .

cla-bot[bot] commented 5 years ago

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Romulo Pires. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails
romulowspp commented 5 years ago

@cla-bot check

cla-bot[bot] commented 5 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @romulowspp. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

cla-bot[bot] commented 5 years ago

The cla-bot has been summoned, and re-checked this pull request!

romulowspp commented 5 years ago

@cla-bot check

cla-bot[bot] commented 5 years ago

The cla-bot has been summoned, and re-checked this pull request!