NativeScript / nativescript-background-http

Background Upload plugin for the NativeScript framework
Apache License 2.0
102 stars 50 forks source link

Supporting webpack #47

Closed hdeshev closed 7 years ago

hdeshev commented 7 years ago

In order to be a webpack-discoverable module, we need to remove the .js suffix in the package.json main attribute. This allows webpack to correctly look for my-module.android.js or my-module.ios.js.

Details here: http://docs.nativescript.org/angular/tooling/bundling-with-webpack.html#referencing-platform-specific-modules-from-packagejson

ignaciolarranaga commented 7 years ago

@PanayotCankov when do you think you can review this PR and release a version ?

ignaciolarranaga commented 7 years ago

@PanayotCankov ? @hdeshev

hdeshev commented 7 years ago

The fix should be up on npm. I'm sorry we had to keep you waiting.

ignaciolarranaga commented 7 years ago

no worries, thanks!