search

NativeScript / nativescript-camera

NativeScript plugin to empower using device camera.
Apache License 2.0
92 stars 47 forks source link

Allow seperate requests for Camera & Photos perms #176

Closed DanielDent closed 5 years ago

DanielDent commented 5 years ago

In some use cases, permission for the camera is all that's needed. This change allows people to request either permission individually.

cla-bot[bot] commented 5 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @danieldent. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

DanielDent commented 5 years ago

@cla-bot check

cla-bot[bot] commented 5 years ago

The cla-bot has been summoned, and re-checked this pull request!

tgpetrov commented 5 years ago

Hi @DanielDent Thank you for your contribution. Could you also mention the newly exposed methods in the README.md file?

DimitarTodorov commented 5 years ago

Hi @DanielDent Since the PR is made from fork, the CI checks would not pass. I've created the same PR in our repo in order to run the CI checks in travis. Once the tests pass, we will merge the PR.

Thanks again for the contribution, NativeScript Team