Add allowsEditing on iOS

msaravitz commented 5 years ago

PR Checklist

[x] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
[x] There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
[x] All existing tests are passing
[x] Tests for the changes are included

What is the current behavior?

https://github.com/NativeScript/nativescript-camera/issues/180

What is the new behavior?

Setting the allowsEditing option to true adds a square crop to images on iOS on the "Retake" "Use Photo" screen. This also allows users to "zoom/crop" after the picture has been taken but before it is used. Fixes/Implements/Closes #[180].

cla-bot[bot] commented 5 years ago

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Matt Saravitz. This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

tgpetrov commented 5 years ago

@msaravitz Thank you for your contribution! Before we proceed with merging your changes, please follow the instructions given by the cla-bot. Also, there seems to be a tslint issue in the demo app. Please make sure running npm run ci.tslint inside the demo folder yields no errors.

cla-bot[bot] commented 5 years ago

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Matt Saravitz. This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] commented 5 years ago

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Matt Saravitz. This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] commented 5 years ago

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Matt Saravitz. This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

msaravitz commented 5 years ago

Something went horribly wrong attempting to fix my config and updating commit author, closing in favor of a new PR.

NativeScript / nativescript-camera