Closed msaravitz closed 5 years ago
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Matt Saravitz. This is most likely caused by a git client misconfiguration; please make sure to:
git config --list | grep email
git config --global user.email email@example.com
@msaravitz Thank you for your contribution!
Before we proceed with merging your changes, please follow the instructions given by the cla-bot.
Also, there seems to be a tslint issue in the demo app.
Please make sure running npm run ci.tslint
inside the demo folder yields no errors.
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Matt Saravitz. This is most likely caused by a git client misconfiguration; please make sure to:
git config --list | grep email
git config --global user.email email@example.com
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Matt Saravitz. This is most likely caused by a git client misconfiguration; please make sure to:
git config --list | grep email
git config --global user.email email@example.com
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Matt Saravitz. This is most likely caused by a git client misconfiguration; please make sure to:
git config --list | grep email
git config --global user.email email@example.com
Something went horribly wrong attempting to fix my config and updating commit author, closing in favor of a new PR.
PR Checklist
What is the current behavior?
https://github.com/NativeScript/nativescript-camera/issues/180
What is the new behavior?
Setting the allowsEditing option to true adds a square crop to images on iOS on the "Retake" "Use Photo" screen. This also allows users to "zoom/crop" after the picture has been taken but before it is used. Fixes/Implements/Closes #[180].