bugfix(android): Fixes crash on sdk27+ devices when saving to gallery - Githubissues

NativeScript / nativescript-camera

NativeScript plugin to empower using device camera.

Apache License 2.0

92 stars 47 forks source link

bugfix(android): Fixes crash on sdk27+ devices when saving to gallery #237

Closed AdamAtri closed 4 years ago

AdamAtri commented 4 years ago

PR Checklist

[x ] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
[x ] There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
[ x] All existing tests are passing
[ x] Tests for the changes are included

What is the current behavior?

On android devices running 27+ the app crashes when saving to the gallery. This is caused by the creation of the picturePath. On 27+ devices the "Camera" directory is not created in the DCIM dir.

What is the new behavior?

The new code creates the 'Camera' directory if it does not exist. Then verifies that there is a file at the expected location

Fixes/Implements/Closes #[225, 236]. BREAKING CHANGES: none Migration steps: none

cla-bot[bot] commented 4 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @AdamAtri. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

AdamAtri commented 4 years ago

@cla-bot check

cla-bot[bot] commented 4 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @AdamAtri. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

cla-bot[bot] commented 4 years ago

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] commented 4 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @AdamAtri. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

AdamAtri commented 4 years ago

@cla-bot check

cla-bot[bot] commented 4 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @AdamAtri. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

cla-bot[bot] commented 4 years ago

The cla-bot has been summoned, and re-checked this pull request!

AdamAtri commented 4 years ago

@cla-bot check

cla-bot[bot] commented 4 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @AdamAtri. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

cla-bot[bot] commented 4 years ago

The cla-bot has been summoned, and re-checked this pull request!

AdamAtri commented 4 years ago

I have signed the cla 3 times and the Travis CLI failures are yours ---> Cannot read property 'SAUCE_USER' of undefined

luke-hawk commented 4 years ago

Hey @AdamAtri – did you give up on this PR?😄 ...I also need a fix for #236 and #225