NativeScript / nativescript-cli

Command-line interface for building NativeScript apps
https://www.npmjs.com/package/nativescript
Apache License 2.0
1.04k stars 195 forks source link

[iOS] MaterialComponents dependency clash #4954

Open charsleysa opened 5 years ago

charsleysa commented 5 years ago

Environment Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

Describe the bug

The hardcoded version of the MaterialComponents/Tabs pod restricts the use of other updated components such as MaterialComponents/ProgressView. It results in an error when installing the pods:

[!] CocoaPods could not find compatible versions for pod "MaterialComponents/ProgressView+Theming":
  In Podfile:
    MaterialComponents/ProgressView+Theming

Specs satisfying the `MaterialComponents/ProgressView+Theming` dependency were found, but they required a higher minimum deployment target.
'pod install' command failed.

To Reproduce

Add a podfile to any project with the following lines:

pod 'MaterialComponents/ProgressView'
pod 'MaterialComponents/ProgressView+Theming'

Expected behavior App compiles fine with no problems.

Sample project

Additional context

One restriction on the iOS side compared to the Android side is that on Android you are able to set variables to modify the library versions that uses, this is currently not true for the iOS side. Adding this capability may be a better long term solution.

oncul commented 5 years ago

i have same issue and i solved with this

pod repo update

KristianDD commented 5 years ago

Hi @charsleysa , It seems that the error is shown, because pod 'MaterialComponents/ProgressView+Theming' doesn't exist. You can check that theming is not implemented for ProgressView here.

charsleysa commented 5 years ago

Hi @KristianDD

The docs are out of date for ProgressView, they haven't been updated in over a year. If you check the source code you'll see that it does in fact exist and has already been released.

https://github.com/material-components/material-components-ios/tree/develop/components/ProgressView/src/Theming