NativeScript / nativescript-cli

Command-line interface for building NativeScript apps
https://www.npmjs.com/package/nativescript
Apache License 2.0
1.04k stars 195 forks source link

ns clean - should remove yarn.lock if the package manager for the project is yarn #5732

Open shiv19 opened 1 year ago

shiv19 commented 1 year ago

Is your feature request related to a problem? Please describe.

When you run ns clean on a project that uses yarn as the package manager, the CLI still tries to remove a package-lock.json instead of yarn.lock

Describe the solution you'd like

If the package manager of the project is yarn, then ns clean should attempt to remove yarn.lock if it exists.

Describe alternatives you've considered

As an alternative, the developer could be prompted if they wish to remove yarn.lock or package-lock.json.

Anything else?

No response

Please accept these terms

rigor789 commented 1 year ago

For 8.6 we're likely going to remove the lockfiles from the default clean paths, and let users opt-in via their own configs... Which you can already do:

cli: {
  additionalPathsToClean: ['yarn.lock']
}

/cc @edusperoni