NativeScript / nativescript-cli

Command-line interface for building NativeScript apps
https://www.npmjs.com/package/nativescript
Apache License 2.0
1.04k stars 195 forks source link

fix(ios): correctly link non dynamic frameworks #5744

Closed farfromrefug closed 1 year ago

farfromrefug commented 1 year ago

Right now all frameworks were embedded and sign even though it should only happen with dynamic framework The code was there but the test was non working and thus all frameworks were embedded and signed.

This is a better PR than https://github.com/NativeScript/nativescript-cli/pull/5743 where we were supposing the framework name was the name of xcframework file. Now we use the info.plist

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

NathanWalker commented 1 year ago

closing as it's dupe: https://github.com/NativeScript/nativescript-cli/pull/5759

farfromrefug commented 1 year ago

@NathanWalker oh yes sorry ;)