NativeScript / nativescript-cli

Command-line interface for building NativeScript apps
https://www.npmjs.com/package/nativescript
Apache License 2.0
1.04k stars 195 forks source link

Replace check for emulator package with check for sdkmanager #5756

Open systemc12ashe opened 1 year ago

systemc12ashe commented 1 year ago

Is your feature request related to a problem? Please describe.

In our case, we only have the emulator package installed for tests and not for the build job. This causes an error “✖WARNING: The Android SDK is not installed or is not configured properly”. CI builds are often run inside containers, and it may not make sense to have an emulator because nested virtualization may not be supported. So now we are made to install the emulator inside a Docker image even though you don’t need an emulator to build an Android binary.

Describe the solution you'd like

It might be more effective to check for the sdkmanager in order to validate whether the Android SDK has been properly installed. The sdkmanager could have the ability to install the emulator if it is missing and required.

Describe alternatives you've considered

Our solution has been to create a workaround in which there is a file that mimics the emulator in order to avoid the error mentioned above.

Anything else?

I hope to contribute to this issue and am actively looking to solve it if approved.

Please accept these terms

rigor789 commented 1 year ago

You can pass the --force flag on CI to skip environment checks, but yes in general improvements to doctor and the checks is something we intend to ship - have a general rewrite in progress on a branch here: https://github.com/NativeScript/nativescript-cli/pull/5674