[fix]: provide appId to webpack config

NativeScript / nativescript-cli

Command-line interface for building NativeScript apps

https://www.npmjs.com/package/nativescript

Apache License 2.0

1.04k stars 195 forks source link

[fix]: provide appId to webpack config #5778

Closed farfromrefug closed 9 months ago

farfromrefug commented 10 months ago

PR Checklist

[ ] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
[ ] There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
[ ] You have signed the CLA.
[ ] All existing tests are passing: https://github.com/NativeScript/nativescript-cli/blob/master/CONTRIBUTING.md#contribute-to-the-code-base
[ ] Tests for the changes are included.

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

vallemar commented 9 months ago

any documentation that for this?

farfromrefug commented 9 months ago

@vallemar dont think so that part of the CLI is not really documented

vallemar commented 9 months ago

@farfromrefug true, I thought that was here https://docs.nativescript.org/configuration/webpack

rigor789 commented 9 months ago

They should be documented here:

Will add once we publish this.

vallemar commented 9 months ago

@rigor789 When I saw that I thought that it could only be passed as a parameter in the terminal, can we add something quick that indicates that those flags can be passed through webpack and a simple example of one??? I would do it myself

rigor789 commented 9 months ago

@vallemar these are internal flags, you wouldn't normally pass them via the terminal unless you're doing something completely out of the ordinary - like running webpack separately on it's own or whatever. The CLI passes these automatically based on nativescript config, and are then used by webpack config to set __ANDROID__ and so globals, enable/disable hmr etc.