ns clean doesnt respect package manager - Githubissues

NativeScript / nativescript-cli

Command-line interface for building NativeScript apps

https://www.npmjs.com/package/nativescript

Apache License 2.0

1.04k stars 195 forks source link

ns clean doesnt respect package manager #5800

Open offizium-berndstorath opened 7 months ago

offizium-berndstorath commented 7 months ago

Issue Description

If I set pnpm as the ns package manager and run ns clean it tries to remove package-lock.json which obviously doesnt exist

Reproduction

Use any ns project
set pnpm as package manager
run ns clean

Relevant log output (if applicable)

No response

Environment

echo 'y' | npx nativescript-envinfo Doesnt show pnpm version. So this makes no sense

Please accept these terms

[X] I have searched the existing issues as well as StackOverflow and this has not been posted before
[X] This is a bug report
[X] I agree to follow this project's Code of Conduct

rigor789 commented 7 months ago

We will remove package-lock.json from ns clean by default in a future release. Users will still be able to configure additionalPathsToClean and add it back, or a different package-manager's lockfile.

Right now this is known/expected behavior, and the file is skipped if not found.