NativeScript / nativescript-cli

Command-line interface for building NativeScript apps
https://www.npmjs.com/package/nativescript
Apache License 2.0
1.04k stars 195 forks source link

fix: apple authentication, appstore list, publish #5820

Open jcassidyav opened 2 weeks ago

jcassidyav commented 2 weeks ago

PR Checklist

What is the current behavior?

Any operation in the CLI which requires an authentication to apple fails with a 401.

What is the new behavior?

Apple authentication changed to a srp implementation, which resulted in the exiting code breaking with an error of 401 on anything that required authentication.

This PR uses a SRP implementation to perform the authentication in the apple way (it is not standard SRP) it consumes a new dependency (@foxt/js-srp) which performs the SRP calculations.

In addition to the authentication, this PR also Fixes:

Fixes/Implements/Closes #5818.

NathanWalker commented 2 weeks ago

Excellent work @jcassidyav ❤️