fix(ios-angular): Topmost deprecation and not rendering on top of modal

NativeScript / nativescript-datetimepicker

Plugin with date and time picking fields

Apache License 2.0

27 stars 26 forks source link

fix(ios-angular): Topmost deprecation and not rendering on top of modal #68

Closed bbroereES closed 3 years ago

bbroereES commented 4 years ago

PR Checklist

[x] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
[x] There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
[x] All existing tests are passing
[ ] Tests for the changes are included

What is the current behavior?

iOS gives a warning about deprecation of topmost() and does not render the datetimepicker on top of a modal in Angular.

What is the new behavior?

iOS gives no warning about deprecation of topmost() and does render the datetimepicker on top of a modal in Angular.

Fixes/Implements/Closes #60.

cla-bot[bot] commented 4 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @bbroereES. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

bbroereES commented 4 years ago

@cla-bot check

cla-bot[bot] commented 4 years ago

The cla-bot has been summoned, and re-checked this pull request!

NathanWalker commented 4 years ago

Thanks @bbroereES !

jscti commented 4 years ago

@NathanWalker Could this be merged ?

lochstar commented 3 years ago

I also need this.

NathanWalker commented 3 years ago

@lochstar and @jscti forgive us for the delay. I went ahead and integrated your fix on this PR just to avoid further delay: https://github.com/NativeScript/plugins/pull/10/files#diff-aad3f150e3a162d27727560b5fa63351R146

That included some formatting to match the style in the workspace but highlighted the diff which contains your change there. Frame.topmost() adjustment was already in there with the {N} 7 updates.

Published in 2.0.2 now.

In future you can PR any changes to the plugin workspace where we manage all @nativescript scope packages: https://github.com/NativeScript/plugins

jscti commented 3 years ago

@NathanWalker Thanks ;)

But I don't get quite how to use it ? Since then I used "tns plugin add nativescript-datetimepicker" (last version : 1.2.2) Now should I use "tns plugin add @nativescript/datetimepicker" (last version today 2.0.2) ? But there is no "NativeScriptDateTimePickerModule" to import

tldr: how to use your fix by "tns plugin add" it ?

edit: Well, I found the proper import : import { NativeScriptDateTimePickerModule } from '@nativescript/datetimepicker/angular'; But it's leading to a "Error: No NgModule metadata found for 'undefined'." ... I'm still on NS6.X edit2: well new repo is only for NS7 ...

jscti commented 3 years ago

@NathanWalker Isn't it possible to merge this PR in this repo as well for NS6 ?

I can't upgrade to NS7 (too much plugins are dead ... ) and I'm struggling forking/building/tns adding this one PR to make it work ... It's a real pain