[BreakingChange] compareElement parameters are not consistent with compareScreen

NativeScript / nativescript-dev-appium

A package to help with writing and executing e2e Appium tests in NativeScript apps

Apache License 2.0

70 stars 27 forks source link

[BreakingChange] compareElement parameters are not consistent with compareScreen #268

Open zbranzov opened 5 years ago

zbranzov commented 5 years ago

compareElement(selected, "selectedState", 50, 5, ImageOptions.pixel) third parameter is the tolerance and I would expect to be the timeout as in compareScreen("initialState", 5, 50, ImageOptions.pixel); and it makes sense as I would rather use the timeout more frequently and then the tolerance paired with the ImageOptions