fix: disregard false matches from chokidar

BenSjoberg commented 5 years ago

Chokidar is firing events for files that don't match the glob when those files are under symlinked directories. Check that the path actually matches ".s[ac]ss" before triggering a compile.

Fixes

PR Checklist

[x] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
[x] There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
[ ] All existing tests are passing
[ ] Tests for the changes are included

What is the current behavior?

On macOS 10.14, having a symlinked directory containing SCSS files causes an infinite compilation loop when using tns run without --bundle.

What is the new behavior?

The loop no longer occuers, so the watcher process behaves as expected.

Fixes #94 & #85.

YvesCandel commented 5 years ago

We've been using this fix in our solution and it works perfectly.

btaluy commented 5 years ago

I've also been using this fix for some time now, Will this ever be merged after a review?

DimitarTachev commented 5 years ago

@BenSjoberg, @YvesCandel, @btaluy, thanks for your help, I marked the related issues as ready for test. Once we verify them, we will release a new version of the plugin.

NativeScript / nativescript-dev-sass