search

NativeScript / nativescript-dev-typescript

TypeScript support for NativeScript projects
Apache License 2.0
21 stars 10 forks source link

Add the ability to pass the --build option to tsc #63

Open jessecrossen opened 5 years ago

jessecrossen commented 5 years ago

I would like to use the --build option that ships with TypeScript 3+, but there seems to be no way to inject it into the tsc arguments list. I can think of two ways to implement this, either specifically for this argument by adding the following to compiler.js: 

if (options.build) {
  nodeArgs.push('--build');
}

or more generally by allowing arbitrary arguments to be passed through:

if (options.args) {
  nodeArgs = nodeArgs.concat(options.args);
}

I'm happy to submit a PR if needed.

jessecrossen commented 5 years ago

Actually on closer inspection it looks like it still wouldn't be easy to pass these options in from the hook scripts in my project, so that might also need to be considered.

jessecrossen commented 5 years ago

Actually this is much more complex than I had thought. I'd still like the feature, but doubt I'm up to submitting an acceptable PR. Among other things, a clean solution will depend on this issue being resolved: https://github.com/Microsoft/TypeScript/issues/26147