fix(hmr): check for hot update should not create new file

miroslavaivanova commented 5 years ago

Currently the check for hot update creates a new file in case it does not exist (as the method from tns-core-modules is doing this). This is a problem when trying to install .ipa on device and the .ipa file contains JavaScript files with HMR enabled. This may happen in case you run tns run ios on device and after command finishes the execution open the project in Xcode and deploy the app from there or uninstall it from device and install the produced .ipa manually. The problem in the mentioned scenarios is that the JavaScript file cannot write files in the directory where the .ipa is installed. When tns run ios is executed, it livesyncs the files in a different location, so the HMR can create the files there.

To fix the issue check if the hmr file exist before reading its content.

PR Checklist

[ ] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
[ ] There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
[ ] You have signed the CLA.
[ ] All existing tests are passing: https://github.com/NativeScript/nativescript-dev-webpack/blob/master/CONTRIBUTING.md#testing-locally-by-running-e2e-tests
[ ] Tests for the changes are included.

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

miroslavaivanova commented 5 years ago

test cli-smoke

miroslavaivanova commented 5 years ago

test --cli

miroslavaivanova commented 5 years ago

test cli-smoke

miroslavaivanova commented 5 years ago

test --ignore

miroslavaivanova commented 5 years ago

test --cli

miroslavaivanova commented 5 years ago

test cli-smoke

NativeScript / nativescript-dev-webpack