NativeScript / nativescript-dev-webpack

A package to help with webpacking NativeScript apps.
Apache License 2.0
97 stars 49 forks source link

fix: stop generating snapshot for ia64 for older runtimes #1032

Closed rosen-vladimirov closed 5 years ago

rosen-vladimirov commented 5 years ago

When the runtime version is below 6.0.2 we should generate snapshot only for armv7, arm64 and ia32 archs. However, as in the validation schema we have default value for the targetArchs, the logic that should determine if ia64 should be removed from the targetArchs decides the archs are passed by the user and does not strip anything from them. Remove the default values from the JSON Schema - they are calculated in the code, so there's no need to have them on two places. As we can not have our conditional logic in the JSON schema, keep calculation of the default values only in the code.

PR Checklist

What is the current behavior?

When Runtime 6.0.1 is used, snapshots are generated for 4 architectures. The ia64 is invalid.

What is the new behavior?

When Runtime 6.0.1 is used, snapshots are generated for 3 architectures.

Fixes/Implements/Closes #[Issue Number].