NativeScript / nativescript-dev-webpack

A package to help with webpacking NativeScript apps.
Apache License 2.0
97 stars 49 forks source link

hmr hot update incorrectly transferred #1065

Open endarova opened 4 years ago

endarova commented 4 years ago

Environment

To Reproduce

  1. tns create app --ng
  2. npm i nativescript-dev-webpack@next --save-dev --save-exact
  3. node_modules/.bin/update-ns-webpack --deps --configs
  4. tns run ios
  5. in app.module.ts change some of the imports to use invalid path
  6. the compilation stops on the error which is expected
  7. fix the error Observe the log: Webpack compilation complete. Watching for file changes. Webpack build done! Successfully transferred bundle.js on device emulator-5554. Successfully transferred runtime.js on device emulator-5554. Successfully transferred vendor.js on device emulator-5554. Successfully transferred 8e8d0cd48028dd74cb35.hot-update.json on device emulator-5554. JS: HMR: Checking for updates to the bundle with hmr hash 8e8d0cd48028dd74cb35. JS: HMR: No Modules Updated. JS: HMR: Successfully applied update with hmr hash 8e8d0cd48028dd74cb35. App is up to date. Restarting application on device emulator-5554... JS: HMR: Hot Module Replacement Enabled. Waiting for signal.

Note: 8e8d0cd48028dd74cb35.hot-update.json should not be transferred

Additional context Not reproducible with nativescript-dev-webpack@1.2.1

Fatme commented 4 years ago

However, it seems as a minor issue as actually the hmr chain is not broken.