search

NativeScript / nativescript-dev-webpack

A package to help with webpacking NativeScript apps.
Apache License 2.0
97 stars 49 forks source link

Webpack compilation doesn't stop on syntactic errors in js/vue apps #1067

Open endarova opened 4 years ago

endarova commented 4 years ago

Environment CLI: @next Plugin(s): nativescript-dev-webpack@next

Describe the bug webpack compilation doesn't stop on syntactic errors in js/vue apps

To Reproduce

  1. tns create js_app --js
  2. npm i nativescript-dev-webpack@next --save-dev --save-exact
  3. node_modules/.bin/update-ns-webpack --deps --configs
  4. tns run iOS
  5. In main-view-model.js make syntactic error (add additional " somewhere) Result: webpack doesn't stop on error the app is deployed and crashes

Expected behavior the build should stop on the error and app should not be deployed broken

Additional context Not reproducible with nativescript-dev-webpack@1.2.1 It is reproducible with run android too

Fatme commented 4 years ago

Currently CLI handles only Module not found errors (wrong require/import) in js/vue applications. This is due to the fact that Module not found errors are handled by webpack itself during the compilation. The .js files inside js/vue applications are processed using raw-loader. It doesn't analyze the code, just copies the content of the file to bundle/vendor. However, using another loader (for example, eslint-loader) will resolve this problem as it'll analyze the code according the give options (.eslint file) and will report them to the webpack. That way, CLI will stop on syntax/semantic errors in js/vue apps.