NativeScript / nativescript-dev-webpack

A package to help with webpacking NativeScript apps.
Apache License 2.0
97 stars 49 forks source link

fix: stop relying on semver as it could be missing in the root node_modules #1075

Closed DimitarTachev closed 4 years ago

DimitarTachev commented 4 years ago

PR Checklist

What is the current behavior?

We are relying on semver while it could be missing in the root node_modules

What is the new behavior?

We are not relying on semver

vakrilov commented 4 years ago

The code file with the hook lives inside the nativescript-dev-webpack package (ehich has semver dependency). So it is ok to rely on it.

It is not ok to rely on semver inside the generated hook file. But in this case it will just execute the script form inside the ns-dev-webpack package.