NativeScript / nativescript-dev-webpack

A package to help with webpacking NativeScript apps.
Apache License 2.0
97 stars 49 forks source link

chore: fix for missing redirects on `@nativescript/angular` #1088

Closed DickSmith closed 4 years ago

DickSmith commented 4 years ago

PR Checklist

What is the current behavior?

ERROR in __REDACTED__/node_modules/@nstudio/nativescript-checkbox/angular/index.js
Module not found: Error: Can't resolve 'nativescript-angular/forms/value-accessors/base-value-accessor' in '__REDACTED__/node_modules/@nstudio/nativescript-checkbox/angular'
ERROR in __REDACTED__/node_modules/nativescript-drop-down/angular/index.js
Module not found: Error: Can't resolve 'nativescript-angular/forms/value-accessors/base-value-accessor' in '__REDACTED__/node_modules/nativescript-drop-down/angular'
ERROR in __REDACTED__/node_modules/@nstudio/nativescript-checkbox/angular/index.js
Module not found: Error: Can't resolve 'nativescript-angular/lang-facade' in '__REDACTED__node_modules/@nstudio/nativescript-checkbox/angular'

What is the new behavior?

From what I've seen for the @nativescript/angular package, all mappings should be 1-1 anyway, so this should work, any exceptions to that assumption can also be remapped here for the specific cases. Fixes/Implements/Closes: https://github.com/nstudio/nativescript-checkbox/issues/118 https://github.com/PeterStaev/NativeScript-Drop-Down/issues/229

rosen-vladimirov commented 4 years ago

Closing as the suggested changes were already merged in this PR Thanks for the great idea @DickSmith