NativeScript / nativescript-dev-webpack

A package to help with webpacking NativeScript apps.
Apache License 2.0
97 stars 49 forks source link

fix: fix module import of local css files #1099

Closed Fatme closed 4 years ago

Fatme commented 4 years ago

There is an issue when importing local css file as module as the css2json-loader handles it as a module instead of a local file. So, the webpack throws an error that it is not able to find the module. This PR fixes this issue as changing the method used to get the correct file uri with the method used by css-loader itself - https://github.com/webpack-contrib/css-loader/blob/967fb66da2545f04055eb0900a69f86e484dd842/src/utils.js#L220.

Rel to: https://github.com/NativeScript/nativescript-dev-webpack/issues/1098

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

Fatme commented 4 years ago

test cli-smoke cli-templates cli-device cli-run

rosen-vladimirov commented 4 years ago

test cli-templates