Webpack do not work for "this.constructor = d;"

ignaciolarranaga commented 8 years ago

For example it does not work for the geolocation module, because of this code (extracted from the bundled code):

!*** ../~/nativescript-geolocation/nativescript-geolocation.ios.js ***!
  \*********************************************************************/
/***/ function(module, exports, __webpack_require__) {

    "use strict";
    var __extends = (this && this.__extends) || function (d, b) {
        for (var p in b) if (b.hasOwnProperty(p)) d[p] = b[p];
        function __() { this.constructor = d; }
        d.prototype = b === null ? Object.create(b) : (__.prototype = b.prototype, new __());
    };

At runtime it throws:

Sep  4 18:04:19 MacBook-Pro-de-Ignacio xxxx[51653]: 1   0x108ff4c67 -[TNSRuntime executeModule:]
Sep  4 18:04:19 MacBook-Pro-de-Ignacio xxxx[51653]: 2   0x106194322 main
Sep  4 18:04:19 MacBook-Pro-de-Ignacio xxxx[51653]: 3   0x10bb6e92d start
Sep  4 18:04:19 MacBook-Pro-de-Ignacio xxxx[51653]: 4   0x1
Sep  4 18:04:19 MacBook-Pro-de-Ignacio xxxx[51653]: file:///app/bundle.js:145226:26: JS ERROR TypeError: Attempted to assign to readonly property.
Sep  4 18:04:19 MacBook-Pro-de-Ignacio com.apple.CoreSimulator.SimDevice.00A4117D-42D7-4D34-A741-4D4FAA4286CD.launchd_sim[96565] (UIKitApplication:com.gynto.client[0x5ed0][51653]): Service exited due to signal: Segmentation fault: 11

This is just an example, but also happen to me on other modules. The only pattern I was able to found is that happends at: function __() { this.constructor = d; }

hdeshev commented 8 years ago

I think the iOS runtime has issues with code using the "use strict" declaration. I think nativescript-geolocation has to be compiled without that.

hdeshev commented 8 years ago

This issue was moved to NativeScript/nativescript-geolocation#32

ignaciolarranaga commented 8 years ago

I don't think it is a problem of geolocation, the "use strict" appears 463 times in my bundle :)

Check for example this piece, it is the app component:

/*!************************!*\
  !*** ./app.context.js ***!
  \************************/
/***/ function(module, exports, __webpack_require__) {

    "use strict";
    var core_1 = __webpack_require__(/*! @angular/core */ 146);
    /**
     * This class represents a particular context (a company selected, a product, selected, etc.)
     */
    var AppContext = (function () {
        function AppContext() {
        }
        AppContext = __decorate([
            core_1.Injectable(), 
            __metadata('design:paramtypes', [])
        ], AppContext);
        return AppContext;
    }());
    exports.AppContext = AppContext;
    //# sourceMappingURL=app.context.js.map

/***/ },

This will also create an issue if the problem where the "use strict"

ignaciolarranaga commented 8 years ago

Tried:

sampleGroceries and does not work: https://github.com/NativeScript/sample-Groceries/issues/158
sample-ng-todomvc and does not work: https://github.com/NativeScript/sample-ng-todomvc/issues/12

In both cases the reason was not the mentioned here, but is there some sample project that I can try ?

hdeshev commented 8 years ago

I don't think it is a problem of geolocation, the "use strict" appears 463 times in my bundle :)

I just tried it, and removing "use strict" from the nativescript-geolocation plugin (upgrading to 0.0.13) fixed it. You can try it in this demo project -- it webpacks and works fine on my end.

ignaciolarranaga commented 8 years ago

Just to comment @hdeshev, @PeterStaev found another solution removing the helpers: https://github.com/PeterStaev/nativescript-purchase/commit/15dcc2855117a7af75177acd40993c26783076e1

hdeshev commented 8 years ago

I saw the related discussion in PeterStaev/nativescript-purchase#4, and I remember having to remove both the decorator helpers and the "use strict" option. Thanks for verifying this!

hdeshev commented 8 years ago

Oh, and one thing I forgot. I'll update the docs article with a section for library maintainers.