fix: the Lazy transformer is not crashing the TypeScript program anymore

DimitarTachev commented 5 years ago

Create PropertyAssignment instead of string literal (Identifier) when modifying the NgModule.

It seems that in some cases (e.g. when there is decomposition in another NgModule property), the TypeScipt program is trying to read node.name.kind for each property causing an exception for Identifiers)

PR Checklist

[x] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
[x] There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
[x] You have signed the [CLA].
[x] All existing tests are passing: https://github.com/NativeScript/nativescript-dev-webpack/blob/master/CONTRIBUTING.md#testing-locally-by-running-e2e-tests
[x] Tests for the changes are included.

DimitarTachev commented 5 years ago

test

DimitarTachev commented 5 years ago

test package_version#rc

NativeScript / nativescript-dev-webpack

fix: the Lazy transformer is not crashing the TypeScript program anymore #959

PR Checklist