Closed NathanaelA closed 5 years ago
Hi @NathanaelA,
Thanks for investigating that!
The resolve
property of the JavaScript Webpack config was not properly configured for symlinked packages and the Webpack compilation was not searching fornode_modules
in the app dir when a symlink is followed.
I've opened a pull request with the proper resolve configuration. You could give it a try by applying the same changes to your local webpack.config.js
.
@DimitarTachev - Awesome; that fixes the demo project... I'll be trying with a couple real plugins tomorrow. :D
Hey @NathanaelA , Did you have time to give it a try? Can we mark this issue as resolved?
Yes, v1.01 I believe fixes the issue. I'll close this unless I run into another one that breaks...
Environment Provide version numbers for the following components (information can be retrieved by running
tns info
in your project folder or by inspecting thepackage.json
of the project):Please note; this is as stock as possible -- I did the following:
tns plugin add ../src
everything should be 100% stock.Describe the bug
To Reproduce
tns build android
(ortns run android
)Expected behavior Works. :grinning:
Sample project Attached.
Additional context This is on Linux. I have not tested this on Windows or Mac. Appears though to be a webpack issue with symlinked plugins.
test-plugin.zip
More information This appears to be a symlink issue -- if I delete the symlink out of the node_modules folder, and then COPY the plugins "src" folder into the demo node_modules folder (and rename src back to the proper name); then building actually works.