search

NativeScript / nativescript-facebook

NativeScript plugin, wrapper of native Facebook SDK for Android and iOS
Apache License 2.0
79 stars 50 forks source link

Github repo updated but not published to npm #143

Closed lin-brian-l closed 5 years ago

lin-brian-l commented 5 years ago

My team and I have been PR #139 and were excited to see that it was merged to master, but the npm registry has not been updated yet. Is there a timeline for when this will happen?

EDIT: I meant to say that we have been following PR #139, we did not have any involvement with the PR. Sorry for any confusion!

elena-p commented 5 years ago

Hi @lin-brian-l,

Once again, thank you and your team for the contribution! We have reviewed the code and our CI tests have passed, but our QAs still need to approve the new functionality and add some tests for it. You can track the status of the Share feature issue here. It will be updated once a new version is published in npm. A rough estimate is that we will have it till the end of the week.

lin-brian-l commented 5 years ago

@elena-p Thanks for the update! I figured out how to build the plugin code locally in the meantime, but I look forward to using the official package.

lin-brian-l commented 5 years ago

@elena-p Thank you for the continued support you and your team put into this plugin :)