search

NativeScript / nativescript-facebook

NativeScript plugin, wrapper of native Facebook SDK for Android and iOS
Apache License 2.0
79 stars 50 forks source link

feat(share): add callback function #166

Closed gogoout closed 5 years ago

gogoout commented 5 years ago

165

Note: during my test, it seems the callback for showMessageDialog is not fired on IOS. Can't figure out why for now. That's why I left the demonstrating for that.

cla-bot[bot] commented 5 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @gogoout. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

cla-bot[bot] commented 5 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @gogoout. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

gogoout commented 5 years ago

@cla-bot check

cla-bot[bot] commented 5 years ago

The cla-bot has been summoned, and re-checked this pull request!

DimitarTodorov commented 5 years ago

Hi, @gogoout I've created a new PR which is the same as yours, since CI tests will not pass if they are triggered from external repo.

Thanks for the contribution.