search

NativeScript / nativescript-facebook

NativeScript plugin, wrapper of native Facebook SDK for Android and iOS
Apache License 2.0
79 stars 50 forks source link

analytics log event methods and ng example #167

Closed narusevic closed 5 years ago

cla-bot[bot] commented 5 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @narusevic. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

DimitarTodorov commented 5 years ago

Hi, @narusevic Thanks for your contribution. I've opened a new PR, which is the same as yours, since the CI checks would not pass when the PR is from external repo.

There are only two more things that we need in order to merge the PR. The first one is to provide description how to use the analytics feature in the Readme file. And the second thing is to include the analytics in the other two demos in the repository - demo-vue and demo. Can you please add those changes and notify us in order to proceed with the merge.

Regards

narusevic commented 5 years ago

Hello,

Ok I will improve my PR at the weekend.

Kind regards Lukas Naruševičius

On 6 Mar 2019, at 14:03, Dimitar Todorov notifications@github.com wrote:

Hi, @narusevic https://github.com/narusevic Thanks for your contribution. I've opened a new PR https://github.com/NativeScript/nativescript-facebook/pull/175, which is the same as yours, since the CI checks would not pass when the PR is from external repo.

There are only two more things that we need in order to merge the PR. The first one is to provide description how to use the analytics feature in the Readme file. And the second thing is to include the analytics in the other two demos in the repository - demo-vue and demo. Can you please add those changes and notify us in order to proceed with the merge.

Regards

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NativeScript/nativescript-facebook/pull/167#issuecomment-470082688, or mute the thread https://github.com/notifications/unsubscribe-auth/AM--oLeFNppd7cNHo7gCOiLPwtRnY0n0ks5vT66rgaJpZM4bAhJY.

DimitarTodorov commented 5 years ago

Hi @narusevic, We are still waiting for your fixes. You can commit them in the related PR. Closing this since it is re-created due to PR checks.