NativeScript / nativescript-facebook

NativeScript plugin, wrapper of native Facebook SDK for Android and iOS
Apache License 2.0
79 stars 50 forks source link

Any plans to update Android to version 5 #201

Closed FranciZ closed 4 years ago

FranciZ commented 5 years ago

App install ads require apps to implement version 5 of the plugin. Are there any plans to upgrade the android side of the plugin to 5?

As far as I see iOS is already on version5.

Thanks!

DimitarTodorov commented 5 years ago

Hi @FranciZ , We've migrated to latest version of iOS android.facebook.sdk since there was an issue, which was fixed in the latest sdk. There was no need at the time being to udpate the android.sdk of the plugin to latest. We will review the changelog of the sdk and will update it at some point. Meanwhile we love contributors and we are open for PRs. You are welcome to update it and propose a PR with the change, we can review and release an update of the plugin after. Regards, NativeScript Team

narusevic commented 5 years ago

After updating to newest tns, angular versions, this error appeared: https://stackoverflow.com/questions/57543127/android-gradle-fail-aapt-error-resource-color-com-facebook-button-background

narusevic commented 5 years ago

Created PR https://github.com/NativeScript/nativescript-facebook/pull/208

zbranzov commented 4 years ago

Published in nativescript-facebook@4.2.0