NativeScript / nativescript-facebook

NativeScript plugin, wrapper of native Facebook SDK for Android and iOS
Apache License 2.0
79 stars 50 forks source link

Updated android to version 5 #208

Closed narusevic closed 5 years ago

narusevic commented 5 years ago

Completes feature request https://github.com/NativeScript/nativescript-facebook/issues/201. Fixes issue https://stackoverflow.com/questions/57543127/android-gradle-fail-aapt-error-resource-color-com-facebook-button-background. Updated according to official upgrade guide https://developers.facebook.com/docs/android/upgrading-4x/

narusevic commented 5 years ago

Build failed, because Encrypted environment variables have been removed for security reasons. See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions Any ideas, why this happened?

elena-p commented 5 years ago

Hi @narusevic,

Thank you for contributing to nativescript-facebook! However our CI checks cannot pass when the PR is from fork. This is why I have opened another PR with your changes that we can approve and merge.