search

NativeScript / nativescript-fresco

This repository holds the NativeScript plugin that exposes the functionality of the Fresco image library to NativeScript developers.
Apache License 2.0
53 stars 23 forks source link

Error after upgrading to NativeScript 2.5 #32

Closed ludwiktrammer closed 7 years ago

ludwiktrammer commented 7 years ago

nativescript-fresco worked great for me with NativeScript 2.4. But after I upgraded to NativeScript 2.5 I get this error when I try to build my application:

node_modules/nativescript-fresco/references.d.ts(1,1): error TS6053: File '/my-project-folder/node_modules/nativescript-fresco/node_modules/tns-core-modules/tns-core-modules.d.ts' not found.

Changing the first line in nativescript-fresco's references.d.ts from:

/// <reference path="./node_modules/tns-core-modules/tns-core-modules.d.ts" />

to

/// <reference path="../tns-core-modules/tns-core-modules.d.ts" />

seems to fix the issue.

VladimirAmiorkov commented 7 years ago

Hi @ludwiktrammer ,

I updated the demo application located here to NativeScript 2.5.0 and was not able to reproduce the mentioned issue. Can you try to reproduce it in the demo app and let me know.

VladimirAmiorkov commented 7 years ago

Closing this issue due to no activity.

ludwiktrammer commented 7 years ago

For what it's worth, after upgrading to NS 3.0 the issue disappeared.