search

NativeScript / nativescript-geolocation

Geolocation plugin to use for getting current location, monitor movement, etc
Apache License 2.0
139 stars 76 forks source link

fix ios accuracy #200

Closed akera-io closed 5 years ago

akera-io commented 5 years ago

When requesting a high accuracy for ios we often receive a not so accurate location due to the fact that when starting update location ios will send a first location as quick as possible although not with the desired accuracy so desiredAccuracy was basically ignored on ios. Since from version 9+ the requestLocation API was introduced thought to use that as well, still if timeout option is specified the good old timer must be used.

VladimirAmiorkov commented 5 years ago

Hi @akera-io ,

I see that there is an CI test that is failing in this PR, can you review it and review your PRs code. The first failure is here: https://travis-ci.org/NativeScript/nativescript-geolocation/jobs/495360697#L347 I see that the error is the same for all failed tests ("Failed: Error: iosLocManager.requestLocation is not a function. (In 'iosLocManager.requestLocation()', 'iosLocManager.requestLocation' is undefined)")

cla-bot[bot] commented 5 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @akera-io. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

akera-io commented 5 years ago

Missed the 'mock' location manager used for tests, did added the new method there and tests seems to pass now.

VladimirAmiorkov commented 5 years ago

@akera-io Thank you. We will proceed with testing and will publish a new version as soon as possible.

elena-p commented 5 years ago

implementation of feature https://github.com/NativeScript/nativescript-geolocation/issues/202