search

NativeScript / nativescript-geolocation

Geolocation plugin to use for getting current location, monitor movement, etc
Apache License 2.0
139 stars 76 forks source link

Update commit dependency with implementation dependency. #288

Open Av1nag opened 1 year ago

Av1nag commented 1 year ago

The java docs are saying that

compile dependency is deprecated in gradle 7.0 and It was supressed by implementation dependency.

If the compile dependency is used the it is arising an error in nativescript-angular project while building android application using ns run android.

jakoguta commented 1 year ago

This needs to be merged.

Av1nag commented 1 year ago

This needs to be merged.

Thank you for recognizing ❤️

NathanWalker commented 1 year ago

Hi @Av1nag and @jakoguta thank you for this. This update is published already in @nativescript/geolocation managed here: https://github.com/NativeScript/plugins/blob/91d0b298ba00c42731346b2291e668c6bc43c66e/packages/geolocation/platforms/android/include.gradle#L15

We should probably archive this repo.

Av1nag commented 1 year ago

Hi @Av1nag and @jakoguta thank you for this. This update is published already in @nativescript/geolocation managed here: https://github.com/NativeScript/plugins/blob/91d0b298ba00c42731346b2291e668c6bc43c66e/packages/geolocation/platforms/android/include.gradle#L15

We should probably archive this repo.

Okay @NathanWalker thank you for responding 🙌