search

NativeScript / nativescript-remote-builds

A NativeScript plugin for remote builds when running and publishing NativeScript apps without env setup.
Apache License 2.0
26 stars 9 forks source link

add circle-token to _isSucessfulBuild api request #8

Closed baquet-fit closed 4 years ago

baquet-fit commented 4 years ago

Include the circleCiApiAccessToken on _isSuccessfulBuild method of circle-ci-service.

Without accessToken the api call to used to monitor the circleci build status isn't authenticated unless the repository is public.

CircleCI will respond to this request made to the api with error: "Message: Project not found".

The error is caught and cancels the build.

cla-bot[bot] commented 4 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @baquet-fit. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

baquet-fit commented 4 years ago

@cla-bot check

cla-bot[bot] commented 4 years ago

The cla-bot has been summoned, and re-checked this pull request!