search

NativeScript / nativescript-ui-charts

NativeScript wrapper around HiCharts library
Apache License 2.0
26 stars 6 forks source link

Added support for HiZones #24

Closed dangrima90 closed 3 years ago

dangrima90 commented 3 years ago

What is the current behavior?

When trying to use zones (Highcharts API; Example) The configuration is not affecting anything in the chart and HiZones are not implemented is shown in the console.

What is the new behavior?

Added the HiZones implementation to the library.

I hope that the mapper I did is correct, I added the properties I saw listed in the Android Highcharts API.

cla-bot[bot] commented 3 years ago

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Daniel Grima. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails
cla-bot[bot] commented 3 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @dangrima90. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

dangrima90 commented 3 years ago

@cla-bot check

cla-bot[bot] commented 3 years ago

The cla-bot has been summoned, and re-checked this pull request!

shiv19 commented 3 years ago

Hi @dangrima90 Thank you for this PR! The changes look good.

Next time you can copy the keys for the mapper from the typings file, it's easier to implement new handlers that way 😃 https://github.com/NativeScript/nativescript-ui-charts/blob/36bb910d28cb76c7c5e7911d337b2c18a0c55db0/src/typings/objc!Highcharts.d.ts#L7102

dangrima90 commented 3 years ago

@shiv19 you're welcome - thanks for merging 👍

Will keep that in mind in case I end up making anymore changes in the future :)

shiv19 commented 3 years ago

It's 1.16am where I live. So I'll release changes in this plugin in the morning :) I'll leave a message here when it is released.

dangrima90 commented 3 years ago

Sounds good! Thank you :)

shiv19 commented 3 years ago

Published as @nativescript/ui-charts@0.1.2 :)

dangrima90 commented 3 years ago

@shiv19 thanks a lot :) just tested it in the application I'm working on - so far so good 👍