search

NativeScript / nativescript-ui-charts

NativeScript wrapper around HiCharts library
Apache License 2.0
26 stars 6 forks source link

fixes bug #17 #25

Closed cjohn001 closed 3 years ago

cjohn001 commented 3 years ago

What is the current behavior?

see bug description. It was not possible to disable the exporting button on ios given the new ios runtime

What is the new behavior?

exporting button is now correctly disabled. Required changing one line of code in plugin in order for boolean values to get correctly mapped to native NSNumber boolean valued objects. Furthermore demo app now requires rc version of runtime which adds the required underlaying bugfix.

Fixes/Implements/Closes #[Issue Number]. fixes bug #17

BREAKING CHANGES: no breaking changes

Migration steps: no migration required

cla-bot[bot] commented 3 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. CLA has not been signed by users: @cjohn001. After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

shiv19 commented 3 years ago

Thanks! @cjohn001 :)

shiv19 commented 3 years ago

@cjohn001 published as @nativescript/ui-charts@0.1.3