search

NativeScript / nativescript-ui-charts

NativeScript wrapper around HiCharts library
Apache License 2.0
26 stars 6 forks source link

fixed issue with angular change detection and updated angular demo to angular v12 #32

Closed cjohn001 closed 3 years ago

cjohn001 commented 3 years ago

@shiv19 : Sorry to make extra work for you again. But I think I now understand why you had changed the plugin interface away from the property system :) Unfortunately, angular change detection seems to not detect the chart updates reliably. it worked in the demo on the emulator but unfortunately not on real devices. This PR should solve this now. I have tested it on real Android and IOS devices and found it to be fine. Please note, I have also updated the demo and angular binding to angular v12, as I had seen a weird issue in the demo which stopped the ui to respond to user interaction after a couple of chart updates. I first suspected my changes to be responsible. However, as those worked fine in my app, which is at angular V12, this looked strange to me. After upgrade to V12 the demo is now also working as expected. Thanks for your time!

shiv19 commented 3 years ago

I already spent an hour on this, but I'm not able to build the src-angular of this plugin after merging this PR.

Will see if Nathan Walker can help me with this on Tuesday. (it'll be Monday for him)

shiv19 commented 3 years ago

Got it working, Published it as @nativescript/ui-charts@0.1.8 Cheers!

cjohn001 commented 3 years ago

OK, great to here! I think we have it sorted out now. I did intensive testing today and will replace now all charts in my app. Hence, in case something will still not work as expected, I will likely get feedback very soon :)