NativeScript / nativescript-ui-charts

NativeScript wrapper around HiCharts library

Apache License 2.0

26 stars 6 forks source link

fix: #38 crash on iOS when using it in the TabView #39

Closed boris01 closed 2 years ago

boris01 commented 2 years ago

PR Checklist

[x] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
[x] There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
[x] All existing tests are passing
[x] Tests for the changes are included

What is the current behavior?

38

What is the new behavior?

Added a selectedViewController in the 116 line (function getVisibleViewController) to prevent endless recursion.

Fixes/Implements/Closes #38 .

shiv19 commented 2 years ago

@boris01 Thanks for working on this :)