Closed markoImake closed 2 years ago
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @markoImake.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check
as a comment to the PR.
@cla-bot check
The cla-bot has been summoned, and re-checked this pull request!
@shiv19 @markoImake Going back to the 9.2.2 eliminate Apple Silicon M1 support and breaking builds!
Hey @boris01 , We're also using Apple Silicon macs. What build error are you getting?
Hey @shiv19 Thanks for the quick reply. Here are the error I'm facing: ld: building for iOS Simulator, but linking in dylib built for iOS, file '***/platforms/ios/Pods/Highcharts/development/Highcharts.framework/Highcharts' for architecture arm64 clang: error: linker command failed with exit code 1 (use -v to see invocation)
As you can see here #35 and here https://github.com/highcharts/highcharts-ios/issues/379 The fix for this were introduced in 9.3+ version. Maybe you are using Rosetta, or you have excluded the ARM64 arch, and this is why you have it working?
I tried and put the latest pod version (pod 'Highcharts', '~> 10.1.0') and it worked for me.
@boris01 Yes I've got this in my build.xcconfig
EXCLUDED_ARCHS__EFFECTIVE_PLATFORM_SUFFIX_simulator__NATIVE_ARCH_64_BIT_x86_64=arm64 arm64e armv7 armv7s armv6 armv8
EXCLUDED_ARCHS=$(inherited) $(EXCLUDED_ARCHS__EFFECTIVE_PLATFORM_SUFFIX_$(EFFECTIVE_PLATFORM_SUFFIX)__NATIVE_ARCH_64_BIT_$(NATIVE_ARCH_64_BIT))
@shiv19 Yes, I don't want to exclude this arch if know that it can work with native M1. Maybe you can open an issue on the Highchart repo with the error you have, or maybe they already fixed it in the latest versions.
@boris01 Okay, I'll investigate this while I'm at work tomorrow. Thanks for your query :)
@shiv19 Thanks
@shiv19 : I would like to ask about the state of your investigation. If the plugin cannot be used in debug builds on apple silicon this is a rather suboptimal situation. Would it not be a possibility in the meantime to upgrade to highcharts 10 when there is a problem with annotations rather than downgrading? I have not observed such issue.
@cjohn001, I am using the plugin on apple silicon without any build issues. We can possibly discuss on how to fix the build error in your project. We can also look at releasing a separate version with highcharts v10
@shiv19 : Sorry for the late reply. I can also build on apple silicon without issue. However, I am having issues with the debugger since I switched to Apple Silicon. When I use the Chrome debugger and look at the network traffic, the requests are permanently shown as loading even so the results where already obtained. When I click on such a package in the chrome debugger the app crashes. I suspect that to be the case due to the interpreted rosetta code. I am currently trying to get rid of a last plugin with old binaries included. Once I have this out, I can tell if my problem is related to the ui-chart plugin or not. Will come back on you as soon as I have things running.
What is the current behavior?
Chart annotations are not visible on the chart (and/or not the correct position) since updating to HighCharts iOS library v9.3.0.
What is the new behavior?
After setting HighCharts iOS library back to v9.2.2, the annotations are working again as it previously did, and showing up in the right position.